[RR] Fast Fixups for FIPS rolling release. #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlaidCat
requested review from
bmastbergen,
Copilot,
kerneltoast,
roxanan1996 and
shreeya-patel98
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull Request Overview
Quick fixes to improve FIPS-related detection and reporting in the rolling release update script.
- Added a DEBUG flag and --debug CLI option for conditional verbose output.
- Changed SHAs collection from a list to a dict mapping commit hashes to touched FIPS directories and enhanced reporting of affected FIPS paths.
- Adjusted output formatting when FIPS-protected changes are detected.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Thess are some quick fixes to account for FIPS difficulties. A future rework is inbound but this needed to get things shipped.
PlaidCat
force-pushed
the
{jmaple}_2025.10.15_fix_fips
branch
from
bf5d815 to
7ccc51b
Compare
roxanan1996
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thess are some quick fixes to account for FIPS difficulties. A future rework is inbound but this needed to get things shipped.
ctrliq/kernel-src-tree#628