added partial key

[DagaBhai]

Issue #23

Solution

• added feature partial key if its a partial match in find_key
• also added partial key and case sensitive to get more precise results

Changes

• changes made in the function find_key and _stack_all_key_values_in_dict

tests

• made a test file test_parser_partial and ran it locally passed all the test cases (should i also added the test in this PR??)

if any changes or suggestion do let me know

[ctomkow]

Hi @DagaBhai, please include your unit test file as well. That will help with my review. Thanks.

[DagaBhai]

ok

[DagaBhai]

@ctomkow pls review the changes

[ctomkow]

@DagaBhai Good work so far. Here are some comments for improvements of your pull request.

When running all the tests, some break. This is due to the new parameters introduced partial and case_sensitive which are currently mandatory.

• They should be optional as to not break existing use of the library.
• Also, ensure the type-hinting is updated as well (the line just below the function def line. This type of type hinting is compatible with py2.7 and beyond.
• Finally, update the docstrings for the Parser class and the docstrings in the functions.py file for the find_key function. The new parameters partial and case_sensitive should be explained what they are and how they work.

Also, in the function _stack_all_key_values_in_dict() please simplify your code.

• Try to adhere to the existing flow of code. i.e.

    if partial:
        match
    elif not partial:
        match
    else:
        stack_push()
        stack_trace()

Thanks!

[DagaBhai]

@DagaBhai Good work so far. Here are some comments for improvements of your pull request.

When running all the tests, some break. This is due to the new parameters introduced partial and case_sensitive which are currently mandatory.

thanks @ctomkow ill will fix the partial and case to false as default

and in the _stack_all_key_values_in_dict() do you have any suggestions to make it simple

also i have my uni exams so i'll work after 26 on this