-
Notifications
You must be signed in to change notification settings - Fork 108
Refactor eleventy proposal #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arkhi
wants to merge
57
commits into
staging
Choose a base branch
from
issues/160-refactor-eleventy
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e53c65e.
* Allow the use of Toml formats. * Add _Global Data Files_ as examples. * Use nunjucks for templates. * Move legacy files into separate folder. * Tweak eleventy.config.js. * Based on _Global Data Files_ participants, use `eleventyComputed` to provide another structure to templates. * Based on _Global Data Files_ participants, use `before` in pagination to provide pagination by years.
1a20506 to
e617de5
Compare
e617de5 to
d86fc0f
Compare
4f02d4b to
bdd398d
Compare
This is more logical as the data is in the same Website object.
* Add editorconfig. * Add eslint. * Add toml eslint plugin.
fe0aa2b to
7326b91
Compare
It can not parse nunjucks template within the permalink.
Member
|
I’m on the road for a few days—will try to review in between but can’t tell yet. |
* Use array-like data to define what to get from the global data. This allows nunjucks filters. * Add globals for first and current year. * Add filters and clean config file a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alifeee made a proposal in a previous PR.
This is a different approach using structured data instead of HTML:
This PR does not touch master for now.
Things in this PR:
Some URL might lead to spam right now, but might have been totally legit websites at the time of submission. This is why some websites were not always removed.
Closes #160 #166.
From HTML to Toml files.
I used the following template and globalData to generate Toml files: