Support 2 digit hex character codes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This acknowledges that character sequences can also be two hex digits instead of 4. The test is still failing as the test is testing against the literal value, which can be represented by "*"
|
This is tricky, since e.g. trailing spaces must be consumed by the escape sequence as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's legal to have ascii characters represented by a two digit hex code.
A real world example is here: https://github.com/twbs/bootstrap/blob/master/less/glyphicons.less#L35
This supports them in the
parseValuesfunction, but the test only half works. Since it's a valid ascii character, it doesn't match when stringified. The stringified value is just the ascii "*".Advice on how to adapt the test would be great.