Pass correct from arg for resolved files
#89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hmm, please don't merge while I'm figuring out with failed tests in css-modules/css-modules-loader-core#89 |
Pass correct 'from' parameter to postcss for files which resolved via `nodeResolve.sync` Incorrect source path leads to wrong names which postcss-plugin-scope generates for example
Contributor
Author
|
Ok, I fixed tests in css-modules/css-modules-loader-core#89. For getting rid of absolute path I pass relative path which calculates from root. |
Member
|
Thanks @anru |
joshwnj
added a commit
that referenced
this pull request
Mar 8, 2016
Pass correct `from` arg for resolved files
Member
|
Published v0.21.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass correct 'from' parameter to postcss for files which resolved via
nodeResolve.syncIncorrect source path leads to wrong names which postcss-plugin-scope generates for example