-
Notifications
You must be signed in to change notification settings - Fork 2
Types: Improve type mappings #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9324bf1 to
120f8ea
Compare
daa7029 to
fea2527
Compare
4732e07 to
a63ce6e
Compare
c3efc82 to
e6837c0
Compare
- Consequently use upper-case type definitions from `sqlalchemy.types`
- Add `timestamp without time zone` types (scalar and array)
- On SQLAlchemy 2, map `real` and `double{_precision}` types to the
newly introduced `sqltypes.{DOUBLE,DOUBLE_PRECISION}` types
All of this is intended to improve reverse type lookups / reflections.
e6837c0 to
1a0e14b
Compare
|
Dear @CaselIT, may we humbly ask you to give this patch a quick review? We started to overhaul the type mapping of the CrateDB dialect the other day, and would like to conclude this patch. Other than filling some gaps, we found that mapping database types to the uppercase type symbol variants provided by SQLAlchemy and back (i.e. using With kind regards, |
|
for reflected tables? it's fine, sqlalchemy types have |
|
Thank you! |
About
sqlalchemy.typestimestamp without time zonetypes (scalar and array)realanddouble{_precision}types to thenewly introduced
sqltypes.{DOUBLE,DOUBLE_PRECISION}typesAll of this is intended to improve reverse type lookups / reflections.
References
ObjectArray.as_generic#23.Backlog