Skip to content

Apache Superset: Validate against version 6.0.0rc2 #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 9, 2025
Merged

Apache Superset: Validate against version 6.0.0rc2 #1208

merged 5 commits into from
Nov 9, 2025

Conversation

@amotl
Copy link
Member

@amotl amotl commented Nov 5, 2025 •
edited
Loading

About

Will Apache Superset 6.x provide full automation capabilities out of the box again?

References

@coderabbitai
Copy link

coderabbitai bot commented Nov 5, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch superset-6.0.0rc2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@amotl amotl force-pushed the superset-6.0.0rc2 branch 4 times, most recently from 6b57a14 to 5982d2a Compare November 5, 2025 22:54
@amotl amotl force-pushed the superset-6.0.0rc2 branch from 2d53c62 to 438bf26 Compare November 5, 2025 22:58
@amotl amotl requested review from hammerhead and surister November 5, 2025 23:04
@amotl amotl marked this pull request as ready for review November 5, 2025 23:04
@amotl amotl mentioned this pull request Nov 5, 2025
Open
amotl
amotl commented Nov 9, 2025
View reviewed changes
application/apache-superset/test.py
Comment on lines -85 to +87
page_body = page.text_content("div.ant-tabs-content-holder")
assert "42 rows" in page_body
assert "Monte Rosa" in page_body
page.wait_for_load_state()

# Verify SQL Lab response.
locator = page.locator("body")
# expect(locator).to_contain_text("42 rows")
expect(locator).to_contain_text("Monte Rosa")
Copy link
Member Author

@amotl amotl Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"42 rows" doesn't appear within the selected element any longer, even after extending its coverage to the whole HTML body. Well, visually it's there, but we don't care too much about such details. This quick integration test wants to verify that data passes through, so it's enough that "Monte Rosa" appears within the response to the query.

@amotl amotl merged commit 21990b6 into main Nov 9, 2025
7 checks passed
@amotl amotl deleted the superset-6.0.0rc2 branch November 9, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@surister surister surister approved these changes

@hammerhead hammerhead Awaiting requested review from hammerhead

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amotl @surister