Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented Nov 28, 2022

In order to set the stage for #16, the patch removes outdated mechanisms to run CrateDB, and uses Docker instead. It also switches CI from Travis CI to GitHub Actions.

@amotl amotl requested a review from hammerhead November 28, 2022 14:52
@amotl amotl marked this pull request as ready for review November 28, 2022 14:52
Install project and invoke test suite.
```shell
bundle install
bundle exec rspec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to run the tests locally on this branch, but it didn't work:
/Users/user/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/activesupport-4.1.16/lib/active_support/core_ext/object/duplicable.rb:82:in <class:BigDecimal>: undefined method new for BigDecimal:Class (NoMethodError)

Will this be fixed with #16?

Copy link
Member Author

@amotl amotl Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined method new for BigDecimal:Class (NoMethodError)

Yes, and a few more subsequent errors as well. Now that I've made it pretty far with the patch, I think making it work completely, and successfully, is almost around the corner.

If you like, and if you can spare some minutes, I will be happy about any help on #16. I will rebase the patch upon this one, after it has been integrated. Making CI work again will probably help for this task.

@amotl amotl force-pushed the amo/travis-to-gha branch from 261345a to bacb64d Compare November 29, 2022 11:29
@amotl amotl requested a review from hammerhead November 29, 2022 11:31
@amotl amotl merged commit 1deb0b1 into master Nov 29, 2022
@amotl amotl deleted the amo/travis-to-gha branch November 29, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants