Adding recording to hits for validation and login #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solarissmoke
requested changes
May 6, 2019
| UserModel = get_user_model() | ||
|
|
||
|
|
||
| class PwnedRecord(models.Model): |
Collaborator
There was a problem hiding this comment.
I'm not sure that this app should be providing this model at all, especially with fields (notified) that it doesn't itself use. To me this seems like a good candidate for a signal instead, which projects can then do what they like with - and would allow a much wider set up use cases without creating a potentially unused table in the database.
| from django.db import models | ||
|
|
||
|
|
||
| UserModel = get_user_model() |
craigloftus
force-pushed
the
master
branch
7 times, most recently
from
dc860d3 to
306d51d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding support for checking of passwords at login, though without any kind of error thrown to the user, as we can't get in the way of a user logging in.
Also adds a model to record hits for logins and validations, so the user can be notified after the fact, in a nice long form email.