-
Notifications
You must be signed in to change notification settings - Fork 11
Minor changes #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Minor changes #120
Conversation
Summary of ChangesHello @azaddhirajkumar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request contains minor textual adjustments within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the terminology in the UI of the chat_with_pdf_query.py demo, replacing references to "GSI" and "N1QL" with "Query". The changes improve clarity and consistency. However, one reference to the old terminology was missed. My review includes a suggestion to fix this remaining inconsistency.
|
|
||
| st.markdown( | ||
| "For RAG, we are using [Langchain](https://langchain.com/), [Couchbase GSI Vector Search](https://couchbase.com/) & [OpenAI](https://openai.com/). We fetch parts of the PDF relevant to the question using N1QL-based Vector search & add it as the context to the LLM. The LLM is instructed to answer based on the context from the Vector Store." | ||
| "For RAG, we are using [Langchain](https://langchain.com/), [Couchbase GSI Vector Search](https://couchbase.com/) & [OpenAI](https://openai.com/). We fetch parts of the PDF relevant to the question using Query based Vector search & add it as the context to the LLM. The LLM is instructed to answer based on the context from the Vector Store." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a small inconsistency here. While you've updated N1QL-based Vector search to Query based Vector search in this line, and changed the page title from (GSI Vector Search) to (Query Vector Store) on line 226, the term Couchbase GSI Vector Search remains. For consistency with the other changes, you should update this as well.
| "For RAG, we are using [Langchain](https://langchain.com/), [Couchbase GSI Vector Search](https://couchbase.com/) & [OpenAI](https://openai.com/). We fetch parts of the PDF relevant to the question using Query based Vector search & add it as the context to the LLM. The LLM is instructed to answer based on the context from the Vector Store." | |
| "For RAG, we are using [Langchain](https://langchain.com/), [Couchbase Query Vector Search](https://couchbase.com/) & [OpenAI](https://openai.com/). We fetch parts of the PDF relevant to the question using Query based Vector search & add it as the context to the LLM. The LLM is instructed to answer based on the context from the Vector Store." |
No description provided.