-
Notifications
You must be signed in to change notification settings - Fork 5
DA-1253: Update Haystack Rag Demo to use Couchbase 8.0+ Vector Indexes #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @VirajAgarwal1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Haystack RAG demo by providing specialized tutorials for different Couchbase vector indexing capabilities. It introduces a new guide for integrating with Couchbase 8.0+'s Hyperscale Vector Index, optimized for large-scale, pure vector search, and refines the existing tutorial to focus on Couchbase 7.6+'s Search Vector Index for hybrid search scenarios. Both approaches now benefit from automated index creation, streamlining the setup process for users and offering clearer guidance based on their Couchbase version and specific vector search needs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request does a great job of updating the Haystack RAG demo to support Couchbase 8.0+ vector indexes by splitting the tutorial into two distinct guides: one for Hyperscale Vector Index (query-based) and another for Search Vector Index (search-based). This separation significantly improves clarity for users. The new Hyperscale tutorial is comprehensive, and the existing tutorial has been effectively updated for SVI. I've identified several areas for improvement, primarily within the new tutorial, including typos, grammatical errors, incorrect code snippets with missing imports, and some conceptual inaccuracies such as a reference to LangChain and flawed logic for a pure LLM call. Addressing these points will greatly enhance the quality and correctness of these valuable tutorials.
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/search_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/search_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Outdated
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/query_based/python-haystack-pdf-chat.md
Show resolved
Hide resolved
| filter: sdk | ||
| technology: | ||
| - fts | ||
| - vector search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that makes the tutorial tag less verbose... Also, search could also mean plain FTS... I believe we should stick with vector search similar to other Vector search tutorials...
tutorial/markdown/python/python-haystack-pdf-chat/python-haystack-pdf-chat.md
Show resolved
Hide resolved
tutorial/markdown/python/python-haystack-pdf-chat/python-haystack-pdf-chat.md
Show resolved
Hide resolved
- Add details on Hyperscale and Composite Vector Indexes - update model version to GPT-5 - Improve clarity on Couchbase integration
No description provided.