Skip to content

Conversation

@relusc
Copy link

@relusc relusc commented Oct 17, 2025

What this PR does:

Removes all references to bitnami images and subcharts (namely memcached). The plan would be to not be able to install memcached by default since cortex can run without it. The deployment of memcached is up to the cortex user and is not in the responsibility of the chart anymore.

Which issue(s) this PR fixes:
It doesn't really fix an issue, but it relates to #548

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX], [DEPENDENCY]

@relusc relusc force-pushed the removeBitnamiReferences branch from 1711511 to 7d05142 Compare October 17, 2025 14:41
Copy link
Collaborator

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks just some tiny nit

@nschad nschad changed the title Remove bitnami references Drop bitnami from helm chart Oct 20, 2025
@nschad nschad changed the title Drop bitnami from helm chart Drop in-built support for bitnami's memcached Oct 20, 2025
@relusc relusc requested a review from nschad October 20, 2025 07:23
@nschad nschad requested a review from kd7lxl October 20, 2025 08:03
Copy link
Collaborator

@kd7lxl kd7lxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/guides/configure_memcached.markdown will need to be updated as well.

@relusc relusc requested review from kd7lxl and nschad October 21, 2025 08:36
@relusc
Copy link
Author

relusc commented Oct 21, 2025

@kd7lxl @nschad I updated the guide and also readded some of the values. I figured that I still want to be able to reference a memcached installation for the components, but I don't want the chart to install them for me

@nschad
Copy link
Collaborator

nschad commented Oct 21, 2025

@kd7lxl @nschad I updated the guide and also readded some of the values. I figured that I still want to be able to reference a memcached installation for the components, but I don't want the chart to install them for me

You can also add CLI Flags via the already existing extraArgs directive. I don't know if we want to keep the helpers, don't really have a strong opinion about it.

@relusc
Copy link
Author

relusc commented Oct 21, 2025

i am fine with both, however for me as a user i'd rather have these extra opts. but that's just my personal opinion

@relusc
Copy link
Author

relusc commented Oct 27, 2025

hi guys, any updates here ? :)

@relusc relusc force-pushed the removeBitnamiReferences branch from dc8a1ca to ae17361 Compare October 27, 2025 09:19
@relusc
Copy link
Author

relusc commented Oct 27, 2025

chart tests should be fixed now: ae17361

@relusc
Copy link
Author

relusc commented Oct 30, 2025

hi, once again i'm bumping here, is anything still missing or what is planned here ? :)

@nschad
Copy link
Collaborator

nschad commented Oct 30, 2025

hi, once again i'm bumping here, is anything still missing or what is planned here ? :)

Personally I still don't really like the half helpers.tpl for memcached? I would honestly remove it

WDYT @kd7lxl

@kd7lxl
Copy link
Collaborator

kd7lxl commented Nov 12, 2025

My opinion is that the built-in memcached support adds value and is not too onerous to maintain. We should keep it. It's also easy to disable for users who want to provide their own.

I would accept a guide that documents how to disable the built-in memcached with values and provide your own.

Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
@relusc relusc force-pushed the removeBitnamiReferences branch from c65b18c to 29710aa Compare November 13, 2025 13:21
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
@relusc relusc force-pushed the removeBitnamiReferences branch from 29710aa to fc8a5e9 Compare November 13, 2025 13:22
@relusc
Copy link
Author

relusc commented Nov 13, 2025

@kd7lxl I added a section how to set the memcached deployments without using the dedicated section in the values. let me know if this is not what you wanted, as I was not completely sure myself what kind of documentation you asked for 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants