-
Notifications
You must be signed in to change notification settings - Fork 169
Drop in-built support for bitnami's memcached #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1711511 to
7d05142
Compare
nschad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks just some tiny nit
kd7lxl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/guides/configure_memcached.markdown will need to be updated as well.
You can also add CLI Flags via the already existing |
|
i am fine with both, however for me as a user i'd rather have these extra opts. but that's just my personal opinion |
|
hi guys, any updates here ? :) |
dc8a1ca to
ae17361
Compare
|
chart tests should be fixed now: ae17361 |
|
hi, once again i'm bumping here, is anything still missing or what is planned here ? :) |
Personally I still don't really like the half helpers.tpl for memcached? I would honestly remove it WDYT @kd7lxl |
|
My opinion is that the built-in memcached support adds value and is not too onerous to maintain. We should keep it. It's also easy to disable for users who want to provide their own. I would accept a guide that documents how to disable the built-in memcached with values and provide your own. |
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
c65b18c to
29710aa
Compare
Signed-off-by: relusc <rene.schach_ext@external.mail.schwarz>
29710aa to
fc8a5e9
Compare
|
@kd7lxl I added a section how to set the memcached deployments without using the dedicated section in the values. let me know if this is not what you wanted, as I was not completely sure myself what kind of documentation you asked for 😅 |
What this PR does:
Removes all references to bitnami images and subcharts (namely memcached). The plan would be to not be able to install memcached by default since cortex can run without it. The deployment of memcached is up to the cortex user and is not in the responsibility of the chart anymore.
Which issue(s) this PR fixes:
It doesn't really fix an issue, but it relates to #548
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX],[DEPENDENCY]