Improve error message when setting aws_region in aws cli config (#1726)

deliahu · web-flow · commit e3d0d88793d8 · 2020-12-22T10:29:42.000-05:00
diff --git a/cli/types/cliconfig/environment.go b/cli/types/cliconfig/environment.go
@@ -110,7 +110,8 @@ func (env *Environment) Validate() error {
 			return errors.Wrap(cr.ErrorMustBeDefined(), env.Name, AWSSecretAccessKeyKey)
 		}
 		if env.AWSRegion != nil {
-			return errors.Wrap(cr.ErrorMustBeEmpty(), env.Name, AWSRegionKey)
+			err := errors.Append(cr.ErrorMustBeEmpty(), " (it's only used for the local environment, since it can be inferred in aws)")
+			return errors.Wrap(err, env.Name, AWSRegionKey)
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,8 @@ func (env *Environment) Validate() error {`
`110`	`110`	`return errors.Wrap(cr.ErrorMustBeDefined(), env.Name, AWSSecretAccessKeyKey)`
`111`	`111`	`}`
`112`	`112`	`if env.AWSRegion != nil {`
`113`		`- return errors.Wrap(cr.ErrorMustBeEmpty(), env.Name, AWSRegionKey)`
	`113`	`+ err := errors.Append(cr.ErrorMustBeEmpty(), " (it's only used for the local environment, since it can be inferred in aws)")`
	`114`	`+ return errors.Wrap(err, env.Name, AWSRegionKey)`
`114`	`115`	`}`
`115`	`116`	`}`
`116`	`117`