Improve error message if failed to pull manager image in CLI (#1725)

Author: deliahu

cli/cmd/lib_manager.go

@@ -63,6 +63,9 @@ func runManager(containerConfig *container.Config, addNewLineAfterPull bool, cop
 
 	pulledImage, err := docker.PullImage(containerConfig.Image, docker.NoAuth, docker.PrintDots)
 	if err != nil {
+		if strings.Contains(err.Error(), "auth") {
+			err = errors.Append(err, fmt.Sprintf("\n\nif your manager image is stored in a private repository: run `docker login` (if you haven't already), download your image with `docker pull %s`, and try this command again)", containerConfig.Image))
+		}
 		return "", nil, err
 	}
 

pkg/lib/docker/errors.go

@@ -76,11 +76,11 @@ func ErrorImageInaccessible(image string, providerType types.ProviderType, cause
 	switch providerType {
 	case types.LocalProviderType:
 		message += fmt.Sprintf("\n\nyou can download your image with `docker pull %s` and try this command again", image)
-		if strings.Contains(cause.Error(), "authorized") || strings.Contains(cause.Error(), "authentication") {
+		if strings.Contains(cause.Error(), "auth") {
 			message += " (if your registry is private, run `docker login` first)"
 		}
 	case types.AWSProviderType:
-		if strings.Contains(cause.Error(), "authorized") || strings.Contains(cause.Error(), "authentication") {
+		if strings.Contains(cause.Error(), "auth") {
 			message += fmt.Sprintf("\n\nif you would like to use a private docker registry, see https://docs.cortex.dev/v/%s/", consts.CortexVersionMinor)
 		}
 	}