-
Notifications
You must be signed in to change notification settings - Fork 175
feat(toolsets): add kiali support #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
85e2e2b to
d3c39c9
Compare
|
It would make sense to provide a little document on this, e.g. in here https://github.com/containers/kubernetes-mcp-server/tree/main/docs ? For instance, when setting the configuration toml to |
|
Sure! I’ll take care of the docs part — I just wanted to get the code reviewed first. |
95fe725 to
1d75415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good, thank!
I created a PR to your branch with some changes to align the new toolset with the rest of implementations:
|
Reviewed and merged. thanks ! |
|
I’ll remove the flags related with Kiali next day. Thanks |
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
Signed-off-by: Marc Nuri <marc@marcnuri.com>
6be0f91 to
27c165c
Compare
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
27c165c to
f03f1c8
Compare
|
Hi! I’ve removed the Kiali configuration and the flags. I’ve also added the rest of the tools that are available so far. |
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
manusa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
However, a few considerations for follow-up PRs.
This is adding close to 20 new tools which might be sort of overwhelming for many LLMs. Especially because it's likely that this toolset will be enabled along with the standard/core kubernetes toolset.
All in all, only with this domain, ~40 tools will be available for the LLM to choose from.
There is also collision of tools (namespaces_list for example), these are already defined.
We might want to consider some of the tools to avoid it. (e.g. the xxx_traces tools could be easily combined into a single tool, probably the metrics too)
The tool descriptions are kind of vague:
- we might want to prepend the tool names with
kiali_oristio_. e.g.healthtool might be very confusing for the LLM - Some descriptions mention "the mesh", maybe we want to add the Istio word too.
workload_logs: Doesn't this provide similar features as pods_log?
|
|
||
| ### Available tools (initial) | ||
|
|
||
| <details> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This essentially duplicates what's shown in the main README.md file but it's not automatically generated.
As a follow-up we might want to either generate this automatically, or remove it from here and link to the main readme.
Thanks! Totally agree — we’re happy to simplify things in a follow-up PR. For now, we’ve been experimenting with which tools can provide the most useful information to the LLM, but we’ll definitely review and consolidate them where possible. Regarding the namespaces overlap, our implementation only returns the namespaces that belong to the mesh, not all Kubernetes namespaces. This distinction is intentional, since the LLM uses it specifically to inspect mesh-related namespaces rather than the full cluster scope. About the logs — good point! I’ll discuss it with the team, since it’s true that workload_logs already aggregates the logs from the pods, so we could probably remove the pod-level one. In fact, we’ve noticed that the LLM sometimes makes multiple calls in sequence, so we were already considering grouping some of them. That will definitely be our next step. Thanks again for the feedback! |
Adding kiali toolset to kubernetes-mcp
kiali-urlwhen Kiali is enabled (via flag or config).We'll add others later after this first PR
cc @hhovsepy