-
Notifications
You must be signed in to change notification settings - Fork 64
[infrastructure] Add compatibility rule in order to consume packages from Conan Center #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
uilianries
wants to merge
2
commits into
conan-io:main
Choose a base branch
from
uilianries:ci/apple-cci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| from conan.tools.build import supported_cppstd, supported_cstd | ||
|
|
||
|
|
||
| def cppstd_compat(conanfile): | ||
| """Compute compatibility factors for different cppstd and cstd versions. | ||
| By default, different compiler.cppstd and compiler.cstd are compatible. | ||
| Returns a list of lists of dicts, each sublist is a potential factor with different settings. | ||
| """ | ||
| extension_properties = getattr(conanfile, "extension_properties", {}) | ||
| compiler = conanfile.settings.get_safe("compiler") | ||
| compiler_version = conanfile.settings.get_safe("compiler.version") | ||
| cppstd = conanfile.settings.get_safe("compiler.cppstd") | ||
| if not compiler or not compiler_version: | ||
| return [] | ||
| factors = [] # List of list, each sublist is a potential combination | ||
| if cppstd is not None and extension_properties.get("compatibility_cppstd") is not False: | ||
| cppstd_possible_values = supported_cppstd(conanfile) | ||
| if cppstd_possible_values is None: | ||
| conanfile.output.warning(f'No cppstd compatibility defined for compiler "{compiler}"') | ||
| else: # The current cppst must be included in case there is other factor | ||
| factors.append([{"compiler.cppstd": v} for v in cppstd_possible_values]) | ||
|
|
||
| cstd = conanfile.settings.get_safe("compiler.cstd") | ||
| if cstd is not None and extension_properties.get("compatibility_cstd") is not False: | ||
| cstd_possible_values = supported_cstd(conanfile) | ||
| if cstd_possible_values is None: | ||
| conanfile.output.warning(f'No cstd compatibility defined for compiler "{compiler}"') | ||
| else: | ||
| factors.append([{"compiler.cstd": v} for v in cstd_possible_values if v != cstd]) | ||
| return factors | ||
|
|
||
|
|
||
| def compatibility(conanfile): | ||
| """Compute all compatibility settings combinations for a given conanfile. | ||
| Returns a list of dicts with "settings" key containing a list of (key, value) tuples. | ||
| """ | ||
| factors = cppstd_compat(conanfile) | ||
|
|
||
| # MSVC 194->193 fallback compatibility | ||
| compiler = conanfile.settings.get_safe("compiler") | ||
| compiler_version = conanfile.settings.get_safe("compiler.version") | ||
| if compiler == "msvc": | ||
| msvc_fallback = {"194": "193"}.get(compiler_version) | ||
| if msvc_fallback: | ||
| factors.append([{"compiler.version": msvc_fallback}]) | ||
|
|
||
| # Apple Clang 17->13 fallback compatibility | ||
| if compiler == "apple-clang" and compiler_version == "17": | ||
| factors.append([{"compiler.version": "13"}]) | ||
|
|
||
| # Linux GCC 13->11 fallback compatibility | ||
| if compiler == "gcc" and compiler_version == "13": | ||
| factors.append([{"compiler.version": "11"}]) | ||
|
|
||
| # Combine factors to compute all possible configurations | ||
| combinations = _factors_combinations(factors) | ||
| # Final compatibility settings combinations to check | ||
| return [{"settings": [(k, v) for k, v in comb.items()]} for comb in combinations] | ||
|
|
||
|
|
||
| def _factors_combinations(factors): | ||
| """Given a list of factors (each factor is a list of dicts), compute all combinations. | ||
| Returns a list of dicts with all combinations of the input factors. | ||
| """ | ||
| combinations = [] | ||
| for factor in factors: | ||
| if not combinations: | ||
| combinations = factor | ||
| continue | ||
| new_combinations = [] | ||
| for comb in combinations: | ||
| for f in factor: | ||
| new_comb = comb.copy() | ||
| new_comb.update(f) | ||
| new_combinations.append(new_comb) | ||
| combinations.extend(new_combinations) | ||
| return combinations | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this safe? I know the concerns between compiler majors is a bit different from clang to gcc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of, it builds, it passes, and it's only for examples2 CI proposal, no upload involved. 😄