Skip to content

Conversation

@bearomorphism
Copy link
Contributor

… hint

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

When running poetry doc, any broken internal documentation links will be reported in the console output like this:

INFO    -  Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

Expected Behavior

Steps to Test This Pull Request

Additional Context

@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v4-9-2@e3bb6d7). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             v4-9-2    #1632   +/-   ##
=========================================
  Coverage          ?   98.72%           
=========================================
  Files             ?       60           
  Lines             ?     2663           
  Branches          ?        0           
=========================================
  Hits              ?     2629           
  Misses            ?       34           
  Partials          ?        0           
Flag Coverage Δ
unittests 98.72% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-W Lee-W added this to the 4.10.0 milestone Oct 8, 2025
@Lee-W Lee-W changed the title refactor(Commit): refactor _prompt_commit_questions and fix some type… refactor(Commit): refactor _prompt_commit_questions and fix some type hint Nov 8, 2025
@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels Nov 8, 2025
@Lee-W Lee-W merged commit 835ccb4 into commitizen-tools:v4-9-2 Nov 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check type: bug type: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants