refactor(Init): make project_info a module and remove self.project_info #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
bearomorphism
force-pushed
the
project-info-refactor
branch
from
ac64612 to
d58b017
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-9-2 #1605 +/- ##
=========================================
Coverage ? 98.72%
=========================================
Files ? 60
Lines ? 2662
Branches ? 0
=========================================
Hits ? 2628
Misses ? 34
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
project-info-refactor
branch
from
d58b017 to
e22fcb3
Compare
woile
approved these changes
Sep 15, 2025
Contributor
Author
|
Thanks for the quick review! |
bearomorphism
commented
Sep 15, 2025
Lee-W
reviewed
Sep 15, 2025
Lee-W
reviewed
Sep 18, 2025
bearomorphism
force-pushed
the
project-info-refactor
branch
2 times, most recently
from
293b265 to
e03b1f0
Compare
Lee-W
approved these changes
Nov 8, 2025
Lee-W
force-pushed
the
project-info-refactor
branch
from
e03b1f0 to
8229584
Compare
Lee-W
added
pr-status: ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
project_infoa module asProjectInfoonly contains stateless helpers.