refactor(cargo_provider): cleanup and get rid of potential type errors #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-10-1 #1599 +/- ##
==========================================
Coverage ? 98.33%
==========================================
Files ? 58
Lines ? 2701
Branches ? 0
==========================================
Hits ? 2656
Misses ? 45
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
cargo-provider-refactor
branch
from
de6dcff to
36698e7
Compare
bearomorphism
force-pushed
the
cargo-provider-refactor
branch
from
efb485a to
1c1c09d
Compare
Lee-W
requested changes
Nov 8, 2025
| return document["workspace"]["package"]["version"] # type: ignore[index,return-value] | ||
| def get(self, document: TOMLDocument) -> str: | ||
| out = _try_get_workspace(document)["package"]["version"] | ||
| assert isinstance(out, str) |
Member
There was a problem hiding this comment.
I'm surprised our linting rule does not block this. I'll create another PR for that. But no, I don't think we should allow assert in production code. If we want to make mypy happy
if TYPE_CHCKING:
assert ...should be used insetad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context