-
-
Notifications
You must be signed in to change notification settings - Fork 302
refactor(bump): cleanup related to update_version_file #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9e1cee1 to
b1ec6b2
Compare
b1ec6b2 to
4760b73
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-9-2 #1594 +/- ##
=========================================
Coverage ? 98.71%
=========================================
Files ? 60
Lines ? 2654
Branches ? 0
=========================================
Hits ? 2620
Misses ? 34
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4760b73 to
f27f093
Compare
82fc109 to
10d5b2f
Compare
commitizen/bump.py
Outdated
| file.write(version_file) | ||
| file.write(bumped_version_file_content) | ||
| updated.append(path) | ||
| return updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw the return value is not covered in the unit tests for this function. I'm not sure if it's covered anywhere else.
10d5b2f to
ee86b9c
Compare
7e0a521 to
6ede88e
Compare
6ede88e to
a5aa553
Compare
Description
Try to address confusing variable names and function names, also reduced the number of function parameters for better readability.
Relate #1580
Better test coverage for
update_version_in_file:check_consistency=TrueencodingvaluesChecklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context