-
-
Notifications
You must be signed in to change notification settings - Fork 302
feat(conventional_commits): Add exclamation on commit title for breaking change #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(conventional_commits): Add exclamation on commit title for breaking change #1576
Conversation
79a72cd to
dad2e40
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-9-2 #1576 +/- ##
=========================================
Coverage ? 98.72%
=========================================
Files ? 60
Lines ? 2667
Branches ? 0
=========================================
Hits ? 2633
Misses ? 34
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cf7c06d to
f69f73f
Compare
f69f73f to
186fbd8
Compare
|
After a rebase on master, I had to add following fix 186fbd83fc7d2fa8c363fa2a08a7d901a657517c to get tests passed. |
|
yep, this needs #1591 to be merged |
186fbd8 to
2dac9eb
Compare
|
Ready for review. |
Add a configuration (disable by default) to allow exclamation in commit title to ease identify BC simple git log parsing. Signed-off-by: Sebastien Fusilier <sebastien.fusilier@gmail.com>
2dac9eb to
e923fc7
Compare
e923fc7 to
2856582
Compare
Force consistent terminal width for tests to avoid wrapping differences between single and multi-worker pytest modes Signed-off-by: Sebastien Fusilier <sebastien.fusilier@gmail.com>
2856582 to
c995c38
Compare

Add a configuration (disable by default) to allow exclamation in commit title to ease identify BC simple git log parsing.
Description
Conventional commit allow to put breaking change exclamation character in git commit title.
This is a useful convention to identify BC commit from the title only.
As it is supported in commitizen parsing, add the option to generate it.
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context