refactor(Init): fix unbounded variable in _ask_tag_format #1529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-9-0-test #1529 +/- ##
==============================================
Coverage ? 98.07%
==============================================
Files ? 58
Lines ? 2700
Branches ? 0
==============================================
Hits ? 2648
Misses ? 52
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
r-ask-tag-format
branch
from
ac23401 to
0d27725
Compare
bearomorphism
force-pushed
the
r-ask-tag-format
branch
from
0d27725 to
ae143db
Compare
Lee-W
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, the type of
tag_formatisAny | Unbounded | strat the end of the function. Actuallytag_formatis defined for all code paths.is_correct_formatisTrue, thentag_formatis assigned"v$version"and the function returns it.is_correct_formatisFalse, thentag_formatis initialized in the if-block.The function logic should be easier to understand after this change.
Checklist