Skip to content

Conversation

@bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented May 16, 2025

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly

Expected Behavior

Steps to Test This Pull Request

Additional Context

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (refactors@50fd65f). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff              @@
##             refactors    #1422   +/-   ##
============================================
  Coverage             ?   97.78%           
============================================
  Files                ?       57           
  Lines                ?     2614           
  Branches             ?        0           
============================================
  Hits                 ?     2556           
  Misses               ?       58           
  Partials             ?        0           
Flag Coverage Δ
unittests 97.78% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism changed the title refactor: bump refactor(bump): code cleanup and better test coverage May 17, 2025
@bearomorphism
Copy link
Contributor Author

Let me reorganize the commits.

@Lee-W Lee-W changed the base branch from master to refactors May 22, 2025 03:26
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits but ready to merge

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels May 22, 2025
@Lee-W Lee-W merged commit 986f8a6 into commitizen-tools:refactors May 25, 2025
18 checks passed
@bearomorphism bearomorphism deleted the refactor-bump branch June 1, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants