-
-
Notifications
You must be signed in to change notification settings - Fork 301
refactor(bump): code cleanup and better test coverage #1422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(bump): code cleanup and better test coverage #1422
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1422 +/- ##
============================================
Coverage ? 97.78%
============================================
Files ? 57
Lines ? 2614
Branches ? 0
============================================
Hits ? 2556
Misses ? 58
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Let me reorganize the commits. |
c952dc9 to
e5226f3
Compare
Lee-W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nits but ready to merge
e5226f3 to
6a7b644
Compare
6a7b644 to
cae1410
Compare
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context