-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore: update and pinned prettier to version 3.4.2 and fix ci #7111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use prettier version specified in `package.json` instead of fixed versions from third-party workflows.
code-asher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh that explains why that block kept getting formatted differently. Thank you for fixing this!
|
It seems there are some other dependencies in there that need to be updated, unrelated to this PR, but preventing the merge. https://github.com/coder/code-server/actions/runs/12304253477/job/34343664857 |
Head branch was pushed to by a user without write access
|
Try to using But it looks like E2E Tests are failing: https://github.com/qupig/code-server/actions/runs/12306978786 BTW, I looked at those failing video artifacts, but it seems like every video is blank. I'm not familiar with those parts, maybe you could check the changes v5.0.0-beta.3...5.0.1 and release notes. |
|
Hey, sorry about that, yeah we have not updated Express yet because doing so causes it to completely fail, and as you noticed all you get is a blank screen (I think all of the http requests error or time out). I thought the check was optional, but I suppose it must not be if the auto-merge failed. Edit: hm it is optional, not sure why the auto-merge did not go through. |
|
I will drop that last commit and force merge |
|
Thank you again! |
According to the
Prettierdocumentation, we should always install an exact version:That is, in
package.jsonit should look like"prettier": "3.0.3"instead of"prettier": "^3.0.3".Don’t forget the
--save-exactparameter when installing or updating theprettier:Otherwise, following the Development workflow, one can easily get different
prettierversions and end up withCIfailing, and this is often a source of confusion.Therefore, this PR mainly pinned the version of
prettierand updates it to the latest version v3.4.2 by the way.It's worth noting that I added the
commithash of the actual formatted code in.git-blame-ignore-revsto ignore non-actual code changes for git blame.prettierversion updates take the same action.git-blame-ignore-revsafter mergingThe original CI process uses the third-party workflow
actionsx/prettier@v3with a fixed version ofprettier(currently seems to be 3.0), which is another cause of confusion.We should always use the version specified in
package.json, and always maintain version numbers in one place.The speed difference is insignificant here, and it's not a shortcoming in the overall CI process.