Skip to content

Conversation

@chen-lia
Copy link

@chen-lia chen-lia commented Nov 6, 2020

Remember, this is a shared responsibility between the developer and reviewers, and all parties take ownership of the code when it is merged.

What is the purpose and intent of this pull request?

What will be impacted and what flows and edge cases have you tested?

Developer & Reviewer Checklist

Remember to provide good feedback!

  • Ask, don’t tell.
  • Explain your reasons why code should be changed.
  • Offer ways to simplify or improve code.
  • Be humble, and avoid hyperbole (“NEVER do…”)
  • If it's too complex, feel free to get face-to-face time with the developer (or a design review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants