Skip to content

⚡️ Speed up method TeamsDataSource.teams_team_get_team by 11% #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method TeamsDataSource.teams_team_get_team by 11% #557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backend/python/app/sources/external/microsoft/teams/teams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@


import json
import logging
from dataclasses import asdict
Expand Down Expand Up @@ -176,7 +174,9 @@ async def teams_team_get_team(self, team_id: str, select: Optional[List[str]] =
if skip:
query_params.skip = skip
config = TeamsRequestBuilder.TeamsRequestBuilderGetRequestConfiguration(query_parameters=query_params)
response = await self.client.teams.by_team_id(team_id).get(request_configuration=config)
# Localize attribute lookups
teams_proxy = self.client.teams
response = await teams_proxy.by_team_id(team_id).get(request_configuration=config)
return self._handle_teams_response(response)
except Exception as e:
logger.error(f"Error in teams_team_get_team: {e}")
Expand Down