Skip to content

⚡️ Speed up method TeamsDataSource.get_data_source by 13% #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method TeamsDataSource.get_data_source by 13% #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions backend/python/app/sources/external/microsoft/teams/teams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@


import json
import logging
from dataclasses import asdict
Expand Down Expand Up @@ -75,9 +73,12 @@ class TeamsDataSource:

def __init__(self, client: MSGraphClient) -> None:
"""Initialize with Microsoft Graph SDK client optimized for Teams."""
self.client = client.get_client().get_ms_graph_service_client()
if not hasattr(self.client, "me"):
ms_client = client.get_client()
# Avoid repeated attribute lookup in hasattr by caching
service_client = ms_client.get_ms_graph_service_client()
if not hasattr(service_client, "me"):
raise ValueError("Client must be a Microsoft Graph SDK client")
self.client = service_client
logger.info("Teams client initialized with 727 methods")

def _handle_teams_response(self, response: object) -> TeamsResponse:
Expand Down Expand Up @@ -116,6 +117,7 @@ def _handle_teams_response(self, response: object) -> TeamsResponse:

def get_data_source(self) -> 'TeamsDataSource':
"""Get the underlying Teams client."""
# No further optimization possible for a property accessor
return self

# ========== TEAMS OPERATIONS (95 methods) ==========
Expand Down