Skip to content

⚡️ Speed up method VectorStoreConfig.validate_and_create_config by 30% #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method VectorStoreConfig.validate_and_create_config by 30% #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions mem0/vector_stores/configs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,18 @@ def validate_and_create_config(self) -> "VectorStoreConfig":
provider = self.provider
config = self.config

if provider not in self._provider_configs:
provider_configs = self._provider_configs
if provider not in provider_configs:
raise ValueError(f"Unsupported vector store provider: {provider}")

module = __import__(
f"mem0.configs.vector_stores.{provider}",
fromlist=[self._provider_configs[provider]],
)
config_class = getattr(module, self._provider_configs[provider])
import sys

module_name = f"mem0.configs.vector_stores.{provider}"
module = sys.modules.get(module_name)
if module is None:
module = __import__(module_name, fromlist=[provider_configs[provider]])

config_class = getattr(module, provider_configs[provider])

if config is None:
config = {}
Expand All @@ -60,6 +64,7 @@ def validate_and_create_config(self) -> "VectorStoreConfig":

# also check if path in allowed kays for pydantic model, and whether config extra fields are allowed
if "path" not in config and "path" in config_class.__annotations__:
config = dict(config)
config["path"] = f"/tmp/{provider}"

self.config = config_class(**config)
Expand Down