⚡️ Speed up method ValkeyDB._build_search_query by 43%

[codeflash-ai]

📄 43% (0.43x) speedup for ValkeyDB._build_search_query in mem0/vector_stores/valkey.py

⏱️ Runtime : 14.7 microseconds → 10.3 microseconds (best of 52 runs)

📝 Explanation and details

The optimization achieves a 42% speedup by eliminating a redundant dictionary traversal in the _build_search_query method.

Key optimization:

• Removed the any(value is not None for key, value in filters.items()) check from the initial condition. This was causing the method to iterate through all filter items twice - once to check if any non-None values exist, and again to build the filter parts.

• Simplified the early exit condition to just if not filters: instead of the compound condition, reducing the conditional logic overhead.

Why this is faster:
The original code performed an O(n) traversal of the filters dictionary with the any() generator expression, followed by another O(n) traversal in the main loop. The optimized version eliminates the first traversal, reducing the time complexity from 2×O(n) to O(n) for the common case where filters contain valid values.

Performance characteristics:
Based on the line profiler results, the optimization is most effective when filters are present and contain valid data (the common use case). The time spent in the initial condition check dropped from 42.8% to 15% of total execution time. This optimization particularly benefits scenarios with moderate to large filter dictionaries, as the savings scale linearly with the number of filter key-value pairs.

✅ Correctness verification report:

Test	Status
⚙️ Existing Unit Tests	🔘 None Found
🌀 Generated Regression Tests	🔘 None Found
⏪ Replay Tests	✅ 14 Passed
🔎 Concolic Coverage Tests	🔘 None Found
📊 Tests Coverage	90.0%

⏪ Replay Tests and Runtime

Test File::Test Function	Original ⏱️	Optimized ⏱️	Speedup
test_pytest_testsconfigstest_prompts_py_testsvector_storestest_weaviate_py_testsllmstest_deepseek_py_test__replay_test_0.py::test_mem0_vector_stores_valkey_ValkeyDB__build_search_query	14.7μs	10.3μs	42.9%✅

To edit these changes git checkout codeflash/optimize-ValkeyDB._build_search_query-mhl2xmni and push.