Skip to content

⚡️ Speed up method MarimoComm._publish_msg by 41% #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method MarimoComm._publish_msg by 41% #596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 2 additions & 21 deletions marimo/_plugins/ui/_impl/comm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from typing import TYPE_CHECKING, Any, Callable, Optional, cast

from marimo._loggers import marimo_logger
from marimo._messaging.ops import SendUIElementMessage
from marimo._types.ids import WidgetModelId

if TYPE_CHECKING:
Expand Down Expand Up @@ -184,25 +185,7 @@ def _publish_msg(
metadata = {} if metadata is None else metadata
buffers = [] if buffers is None else buffers

if msg_type == COMM_OPEN_NAME:
self._publish_message_buffer.append(
MessageBufferData(
data, metadata, buffers, model_id=self.comm_id
)
)
self.flush()
return

if msg_type == COMM_MESSAGE_NAME:
self._publish_message_buffer.append(
MessageBufferData(
data, metadata, buffers, model_id=self.comm_id
)
)
self.flush()
return

if msg_type == COMM_CLOSE_NAME:
if msg_type in {COMM_OPEN_NAME, COMM_MESSAGE_NAME, COMM_CLOSE_NAME}:
self._publish_message_buffer.append(
MessageBufferData(
data, metadata, buffers, model_id=self.comm_id
Expand All @@ -218,8 +201,6 @@ def _publish_msg(
)

def flush(self) -> None:
from marimo._messaging.ops import SendUIElementMessage

while self._publish_message_buffer:
item = self._publish_message_buffer.pop(0)
SendUIElementMessage(
Expand Down