Skip to content

⚡️ Speed up function natural_sort by 102% #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function natural_sort by 102% #594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions marimo/_utils/files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,11 @@
from pathlib import Path
from typing import Union

_num_split = re.compile("([0-9]+)").split

def natural_sort(filename: str) -> list[Union[int, str]]:
def convert(text: str) -> Union[int, str]:
return int(text) if text.isdigit() else text.lower()

def alphanum_key(key: str) -> list[Union[int, str]]:
return [convert(c) for c in re.split("([0-9]+)", key)]

return alphanum_key(filename)
def natural_sort(filename: str) -> list[Union[int, str]]:
return [int(c) if c.isdigit() else c.lower() for c in _num_split(filename)]


def get_files(folder: str) -> Generator[Path, None, None]:
Expand Down