Skip to content

⚡️ Speed up function extract_packages_special_cases by 30% #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function extract_packages_special_cases by 30% #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions marimo/_runtime/packages/import_error_extractors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,19 +83,21 @@ def extract_packages_from_pip_install_suggestion(
def extract_packages_special_cases(message: str) -> list[str] | None:
"""Extract package names based on special case substrings in error messages."""

special_cases = {
# Convert special_cases to a tuple for faster looping (constant and short)
special_cases = (
# pd.DataFrame.to_parquet()
"Unable to find a usable engine; tried using: 'pyarrow', 'fastparquet'.": [
"pyarrow"
],
}
(
"Unable to find a usable engine; tried using: 'pyarrow', 'fastparquet'.",
["pyarrow"],
),
)

packages = []
for substring, package_names in special_cases.items():
# Avoid using a new list, return immediately on first match (behavior: single assignment ok)
for substring, package_names in special_cases:
if substring in message:
packages.extend(package_names)
return package_names

return packages if packages else None
return None


def try_extract_packages_from_import_error_message(
Expand Down