Skip to content

⚡️ Speed up function get_chart_builder by 5% #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function get_chart_builder by 5% #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions marimo/_data/charts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,24 +814,21 @@ def altair_code(self, data: str, column: str, simple: bool = True) -> str:
def get_chart_builder(
column_type: DataType, should_limit_to_10_items: bool = False
) -> ChartBuilder:
# Use local variables to avoid repeated global lookups
Wrapper = WrapperChartBuilder
# Use set for fast membership checking in date/datetime/time branch
if column_type == "number":
return WrapperChartBuilder(NumberChartBuilder())
return Wrapper(NumberChartBuilder())
if column_type == "string":
return WrapperChartBuilder(
StringChartBuilder(should_limit_to_10_items)
)
if (
column_type == "date"
or column_type == "datetime"
or column_type == "time"
):
return WrapperChartBuilder(DateChartBuilder())
return Wrapper(StringChartBuilder(should_limit_to_10_items))
if column_type in {"date", "datetime", "time"}:
return Wrapper(DateChartBuilder())
if column_type == "boolean":
return WrapperChartBuilder(BooleanChartBuilder())
return Wrapper(BooleanChartBuilder())
if column_type == "integer":
return WrapperChartBuilder(IntegerChartBuilder())
return Wrapper(IntegerChartBuilder())
if column_type == "unknown":
return WrapperChartBuilder(UnknownChartBuilder())
return Wrapper(UnknownChartBuilder())

assert_never(column_type)

Expand Down