Skip to content

⚡️ Speed up method MCPTransportRegistry.get_connector by 18% #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method MCPTransportRegistry.get_connector by 18% #579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions marimo/_server/ai/mcp/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,12 @@ class MCPTransportRegistry:
"""Registry for MCP transport connectors."""

def __init__(self) -> None:
# Moved local names outside of dict literal to avoid repeated attribute lookups
stdio = MCPTransportType.STDIO
http = MCPTransportType.STREAMABLE_HTTP
self._connectors: dict[MCPTransportType, MCPTransportConnector] = {
MCPTransportType.STDIO: StdioTransportConnector(),
MCPTransportType.STREAMABLE_HTTP: StreamableHTTPTransportConnector(),
stdio: StdioTransportConnector(),
http: StreamableHTTPTransportConnector(),
}

def get_connector(
Expand All @@ -125,6 +128,7 @@ def get_connector(
Raises:
ValueError: If transport type is not supported
"""
if transport_type not in self._connectors:
try:
return self._connectors[transport_type]
except KeyError:
raise ValueError(f"Unsupported transport type: {transport_type}")
return self._connectors[transport_type]