Skip to content

⚡️ Speed up function construct_model_type_cache_path by 33% #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function construct_model_type_cache_path by 33% #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions inference/core/registries/roboflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,8 @@ def _save_model_metadata_in_cache(
def construct_model_type_cache_path(
dataset_id: Union[DatasetID, ModelID], version_id: Optional[VersionID]
) -> str:
cache_dir = os.path.join(
MODEL_CACHE_DIR, dataset_id, version_id if version_id else ""
)
return os.path.join(cache_dir, "model_type.json")
# Combine all path parts at once for efficiency
if version_id:
return os.path.join(MODEL_CACHE_DIR, dataset_id, version_id, "model_type.json")
else:
return os.path.join(MODEL_CACHE_DIR, dataset_id, "model_type.json")