Skip to content

⚡️ Speed up method Contacts.by_name by 79% #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method Contacts.by_name by 79% #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions electrum/contacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
from .util import read_json_file, write_json_file, to_string, is_valid_email
from .logging import Logger, get_logger
from .util import trigger_callback, get_asyncio_loop
from electrum.wallet_db import WalletDB

if TYPE_CHECKING:
from .wallet_db import WalletDB
Expand Down Expand Up @@ -117,9 +118,11 @@ async def resolve_openalias(cls, url: str) -> Dict[str, Any]:
return {}

def by_name(self, name):
for k in self.keys():
_type, addr = self[k]
if addr.casefold() == name.casefold():
# Casefold once for efficiency, otherwise repeated for each item
name_cf = name.casefold()
# Use items() instead of keys + __getitem__; cheaper to iterate and unpack (PY3 dict)
for k, (_type, addr) in self.items():
if addr.casefold() == name_cf:
return {
'name': addr,
'type': _type,
Expand Down