Skip to content

⚡️ Speed up method LooseVersion.__repr__ by 100% #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method LooseVersion.__repr__ by 100% #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion electrum/_vendor/distutils/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,14 @@ def __str__ (self):


def __repr__ (self):
return "LooseVersion ('%s')" % str(self)
# Fast path: avoid python's slow %-format and str() call
# Exploit that __str__ just returns self.vstring for LooseVersion
try:
s = self.vstring
except AttributeError:
s = str(self)
# This uses f-string, which is faster than % formatting
return f"LooseVersion ('{s}')"


def _cmp (self, other):
Expand Down