Skip to content

⚡️ Speed up method BCDataStream.write_int32 by 27% #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method BCDataStream.write_int32 by 27% #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions electrum/transaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,8 +625,15 @@ def read_uint64(self): return self._read_num('<Q')

def write_boolean(self, val): return self.write(b'\x01' if val else b'\x00')
def write_int16(self, val): return self._write_num('<h', val)
def write_uint16(self, val): return self._write_num('<H', val)
def write_int32(self, val): return self._write_num('<i', val)
def write_uint16(self, val):
return self._write_num('<H', val)
def write_int32(self, val):
s = struct.pack('<i', val)
inp = self.input
if inp is None:
self.input = bytearray(s)
else:
inp.extend(s)
def write_uint32(self, val): return self._write_num('<I', val)
def write_int64(self, val): return self._write_num('<q', val)
def write_uint64(self, val): return self._write_num('<Q', val)
Expand Down Expand Up @@ -672,7 +679,18 @@ def _read_num(self, format):

def _write_num(self, format, num):
s = struct.pack(format, num)
self.write(s)
# Inlining BCDataStream.write code here for hot-path speedup.
# This avoids double conversion of bytes to bytearray and repeated type checks.
assert isinstance(s, (bytes, bytearray))
inp = self.input
if inp is None:
# Direct assignment is fastest
self.input = bytearray(s)
else:
# Use extend() instead of += for efficiency (avoids creating a new object)
inp.extend(s)
# Return behavior preserved: The original _write_num doesn't return, but mainline code expects None
# which is the case here.


def script_GetOp(_bytes : bytes):
Expand Down