Skip to content

⚡️ Speed up method Cache.pop by 25% #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method Cache.pop by 25% #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions electrum/lrucache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ def pop(self, _):

_KT = TypeVar("_KT")
_VT = TypeVar("_VT")


class Cache(collections.abc.MutableMapping[_KT, _VT]):
"""Mutable mapping to serve as a simple cache or cache base class."""

Expand Down Expand Up @@ -115,13 +117,14 @@ def get(self, key: _KT, default: _VT = None) -> _VT | None:
return default

def pop(self, key: _KT, default=__marker) -> _VT:
if key in self:
value = self[key]
try:
value = self.__data[key]
del self[key]
elif default is self.__marker:
raise KeyError(key)
else:
value = default
except KeyError:
if default is self.__marker:
raise KeyError(key)
else:
value = default
return value

def setdefault(self, key: _KT, default: _VT = None) -> _VT | None:
Expand Down