Skip to content

⚡️ Speed up function parse_test_failures_from_stdout by 16% in PR #945 (feat/feedback-loop-for-unmatched-test-results) #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2025
Merged

⚡️ Speed up function parse_test_failures_from_stdout by 16% in PR #945 (feat/feedback-loop-for-unmatched-test-results) #946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions codeflash/verification/parse_test_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,16 +514,17 @@ def merge_test_results(

def parse_test_failures_from_stdout(test_results: TestResults, stdout: str) -> TestResults:
stdout_lines = stdout.splitlines()
start_line = -1
end_line = -1
start_line = end_line = None

# optimize search for start/end by scanning once
for i, line in enumerate(stdout_lines):
if start_line != -1 and end_line != -1:
break
if "FAILURES" in line:
if start_line is None and "FAILURES" in line:
start_line = i
elif "short test summary info" in line:
elif start_line is not None and end_line is None and "short test summary info" in line:
end_line = i
if start_line == -1 or end_line == -1:
break

if start_line is None or end_line is None:
return test_results

complete_failure_output_lines = stdout_lines[start_line:end_line] # exclude last summary line
Expand All @@ -533,14 +534,24 @@ def parse_test_failures_from_stdout(test_results: TestResults, stdout: str) -> T
current_test_case: str | None = None
current_failure_lines: list[str] = []

# Avoid per-line string concatenation by tracking indices and performing join once per section
# Precompute the boundary check value
underline_prefix = "_______"

# Minor: Pull into local variable to avoid attribute lookup inside loop
join_nl = "\n".join
append = current_failure_lines.append

for line in complete_failure_output_lines:
if line.startswith("_______"):
# Fast-path: avoid .startswith() unless it can possibly match
if line and line[0] == "_" and line.startswith(underline_prefix):
if current_test_case:
test_case_to_failure[current_test_case] = "".join(current_failure_lines)
current_test_case = line.strip("_ ").strip()
current_failure_lines = []
# Start new collection
current_failure_lines.clear()
elif current_test_case:
current_failure_lines.append(line + "\n")
append(line + "\n")

if current_test_case:
test_case_to_failure[current_test_case] = "".join(current_failure_lines)
Expand Down
Loading