Merge pull request #846 from codeflash-ai/local-setup-fixes

filter optimization reviews before PR

Author: misrasaurabh1

codeflash/api/aiservice.py

@@ -261,7 +261,7 @@ def optimize_python_code_refinement(self, request: list[AIServiceRefinerRequest]
         logger.debug(f"Refining {len(request)} optimizations…")
         console.rule()
         try:
-            response = self.make_ai_service_request("/refinement", payload=payload, timeout=60)
+            response = self.make_ai_service_request("/refinement", payload=payload, timeout=120)
         except requests.exceptions.RequestException as e:
             logger.exception(f"Error generating optimization refinements: {e}")
             ph("cli-optimize-error-caught", {"error": str(e)})
@@ -597,7 +597,7 @@ def get_optimization_review(
         }
         console.rule()
         try:
-            response = self.make_ai_service_request("/optimization_review", payload=payload, timeout=60)
+            response = self.make_ai_service_request("/optimization_review", payload=payload, timeout=120)
         except requests.exceptions.RequestException as e:
             logger.exception(f"Error generating optimization refinements: {e}")
             ph("cli-optimize-error-caught", {"error": str(e)})

codeflash/api/cfapi.py

@@ -158,7 +158,7 @@ def suggest_changes(
         "coverage_message": coverage_message,
         "replayTests": replay_tests,
         "concolicTests": concolic_tests,
-        "optimizationImpact": optimization_review,  # impact keyword left for legacy reasons, touches js/ts code
+        "optimizationReview": optimization_review,  # impact keyword left for legacy reasons, touches js/ts code
     }
     return make_cfapi_request(endpoint="/suggest-pr-changes", method="POST", payload=payload)
 
@@ -200,7 +200,7 @@ def create_pr(
         "coverage_message": coverage_message,
         "replayTests": replay_tests,
         "concolicTests": concolic_tests,
-        "optimizationImpact": optimization_review,  # Impact keyword left for legacy reasons, it touches js/ts codebase
+        "optimizationReview": optimization_review,  # Impact keyword left for legacy reasons, it touches js/ts codebase
     }
     return make_cfapi_request(endpoint="/create-pr", method="POST", payload=payload)
 
@@ -257,7 +257,7 @@ def create_staging(
         "coverage_message": coverage_message,
         "replayTests": replay_tests,
         "concolicTests": concolic_tests,
-        "optimizationImpact": optimization_review,  # Impact keyword left for legacy reasons, it touches js/ts codebase
+        "optimizationReview": optimization_review,  # Impact keyword left for legacy reasons, it touches js/ts codebase
     }
 
     return make_cfapi_request(endpoint="/create-staging", method="POST", payload=payload)

codeflash/optimization/function_optimizer.py

@@ -1458,7 +1458,7 @@ def process_review(
 
         raise_pr = not self.args.no_pr
         staging_review = self.args.staging_review
-
+        opt_review_response = ""
         if raise_pr or staging_review:
             data["root_dir"] = git_root_dir()
             calling_fn_details = get_opt_review_metrics(
@@ -1468,15 +1468,14 @@ def process_review(
                 self.project_root,
                 self.test_cfg.tests_root,
             )
-            opt_review_response = ""
             try:
                 opt_review_response = self.aiservice_client.get_optimization_review(
                     **data, calling_fn_details=calling_fn_details
                 )
             except Exception as e:
                 logger.debug(f"optimization review response failed, investigate {e}")
             data["optimization_review"] = opt_review_response
-        if raise_pr and not staging_review:
+        if raise_pr and not staging_review and opt_review_response != "low":
             data["git_remote"] = self.args.git_remote
             check_create_pr(**data)
         elif staging_review: