Skip to content

Commit 04ab4af

Browse files
committed
filter reviews
1 parent fd36821 commit 04ab4af

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

codeflash/api/aiservice.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ def optimize_python_code_refinement(self, request: list[AIServiceRefinerRequest]
261261
logger.debug(f"Refining {len(request)} optimizations…")
262262
console.rule()
263263
try:
264-
response = self.make_ai_service_request("/refinement", payload=payload, timeout=60)
264+
response = self.make_ai_service_request("/refinement", payload=payload, timeout=120)
265265
except requests.exceptions.RequestException as e:
266266
logger.exception(f"Error generating optimization refinements: {e}")
267267
ph("cli-optimize-error-caught", {"error": str(e)})
@@ -597,7 +597,7 @@ def get_optimization_review(
597597
}
598598
console.rule()
599599
try:
600-
response = self.make_ai_service_request("/optimization_review", payload=payload, timeout=60)
600+
response = self.make_ai_service_request("/optimization_review", payload=payload, timeout=120)
601601
except requests.exceptions.RequestException as e:
602602
logger.exception(f"Error generating optimization refinements: {e}")
603603
ph("cli-optimize-error-caught", {"error": str(e)})

codeflash/api/cfapi.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def suggest_changes(
158158
"coverage_message": coverage_message,
159159
"replayTests": replay_tests,
160160
"concolicTests": concolic_tests,
161-
"optimizationImpact": optimization_review, # impact keyword left for legacy reasons, touches js/ts code
161+
"optimizationReview": optimization_review, # impact keyword left for legacy reasons, touches js/ts code
162162
}
163163
return make_cfapi_request(endpoint="/suggest-pr-changes", method="POST", payload=payload)
164164

@@ -200,7 +200,7 @@ def create_pr(
200200
"coverage_message": coverage_message,
201201
"replayTests": replay_tests,
202202
"concolicTests": concolic_tests,
203-
"optimizationImpact": optimization_review, # Impact keyword left for legacy reasons, it touches js/ts codebase
203+
"optimizationReview": optimization_review, # Impact keyword left for legacy reasons, it touches js/ts codebase
204204
}
205205
return make_cfapi_request(endpoint="/create-pr", method="POST", payload=payload)
206206

@@ -257,7 +257,7 @@ def create_staging(
257257
"coverage_message": coverage_message,
258258
"replayTests": replay_tests,
259259
"concolicTests": concolic_tests,
260-
"optimizationImpact": optimization_review, # Impact keyword left for legacy reasons, it touches js/ts codebase
260+
"optimizationReview": optimization_review, # Impact keyword left for legacy reasons, it touches js/ts codebase
261261
}
262262

263263
return make_cfapi_request(endpoint="/create-staging", method="POST", payload=payload)

codeflash/optimization/function_optimizer.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1458,7 +1458,7 @@ def process_review(
14581458

14591459
raise_pr = not self.args.no_pr
14601460
staging_review = self.args.staging_review
1461-
1461+
opt_review_response = ""
14621462
if raise_pr or staging_review:
14631463
data["root_dir"] = git_root_dir()
14641464
calling_fn_details = get_opt_review_metrics(
@@ -1468,15 +1468,14 @@ def process_review(
14681468
self.project_root,
14691469
self.test_cfg.tests_root,
14701470
)
1471-
opt_review_response = ""
14721471
try:
14731472
opt_review_response = self.aiservice_client.get_optimization_review(
14741473
**data, calling_fn_details=calling_fn_details
14751474
)
14761475
except Exception as e:
14771476
logger.debug(f"optimization review response failed, investigate {e}")
14781477
data["optimization_review"] = opt_review_response
1479-
if raise_pr and not staging_review:
1478+
if raise_pr and not staging_review and opt_review_response != "low":
14801479
data["git_remote"] = self.args.git_remote
14811480
check_create_pr(**data)
14821481
elif staging_review:

0 commit comments

Comments
 (0)