Skip to content

⚡️ Speed up method probit.parse_balance by 28% #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method probit.parse_balance by 28% #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions python/ccxt/async_support/probit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,14 +596,21 @@ def parse_balance(self, response) -> Balances:
'timestamp': None,
'datetime': None,
}
data = self.safe_value(response, 'data', [])
for i in range(0, len(data)):
balance = data[i]
currencyId = self.safe_string(balance, 'currency_id')
code = self.safe_currency_code(currencyId)
account = self.account()
account['total'] = self.safe_string(balance, 'total')
account['free'] = self.safe_string(balance, 'available')
# Local caching of bound methods
safe_value = self.safe_value
safe_string = self.safe_string
safe_currency_code = self.safe_currency_code
account_method = self.account

data = safe_value(response, 'data', [])
# Loop optimizations: hoist method lookup, reduce local dict lookups
for balance in data:
currencyId = safe_string(balance, 'currency_id')
code = safe_currency_code(currencyId)
account = account_method()
# Only two fields are accessed, assign directly for slight speedup
account['total'] = safe_string(balance, 'total')
account['free'] = safe_string(balance, 'available')
result[code] = account
return self.safe_balance(result)

Expand Down
Loading