Skip to content

⚡️ Speed up method xt.parse_trade by 11% #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method xt.parse_trade by 11% #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions python/ccxt/async_support/xt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2153,8 +2153,7 @@ def parse_trade(self, trade, market=None):
if marketType is None:
marketType = 'spot' if hasSpotKeys else 'contract'
market = self.safe_market(marketId, market, '_', marketType)
side = None
takerOrMaker = None
side, takerOrMaker = None, None
isBuyerMaker = self.safe_bool(trade, 'b')
if isBuyerMaker is not None:
side = 'sell' if isBuyerMaker else 'buy'
Expand All @@ -2177,13 +2176,18 @@ def parse_trade(self, trade, market=None):
timestamp = self.safe_integer_n(trade, ['t', 'time', 'timestamp'])
quantity = self.safe_string_2(trade, 'q', 'quantity')
amount = None
contractSize = self.number_to_string(market['contractSize'])
if marketType == 'spot':
amount = quantity
else:
a_val = self.safe_string(trade, 'a')
if quantity is None:
amount = Precise.string_mul(self.safe_string(trade, 'a'), self.number_to_string(market['contractSize']))
amount = Precise.string_mul(a_val, contractSize)
else:
amount = Precise.string_mul(quantity, self.number_to_string(market['contractSize']))
amount = Precise.string_mul(quantity, contractSize)
# Inline currency code logic for performance
feeCurrencyCode = self.safe_string_2(trade, 'feeCurrency', 'feeCoin')
feeCurrency = self.safe_currency_code(feeCurrencyCode)
return self.safe_trade({
'info': trade,
'id': self.safe_string_n(trade, ['i', 'tradeId', 'execId']),
Expand All @@ -2198,7 +2202,7 @@ def parse_trade(self, trade, market=None):
'amount': amount,
'cost': None,
'fee': {
'currency': self.safe_currency_code(self.safe_string_2(trade, 'feeCurrency', 'feeCoin')),
'currency': feeCurrency,
'cost': self.safe_string(trade, 'fee'),
},
}, market)
Expand Down
Loading