Skip to content

⚡️ Speed up method StaticHandler.append_version by 107% #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up method StaticHandler.append_version by 107% #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/bokeh/server/views/static_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ def append_version(cls, path: str) -> str:
if settings.dev:
return path
else:
version = StaticFileHandler.get_version(dict(static_path=settings.bokehjs_path()), path)
if not hasattr(cls, "_static_path_cache"):
cls._static_path_cache = dict(static_path=settings.bokehjs_path())
version = StaticFileHandler.get_version(cls._static_path_cache, path)
return f"{path}?v={version}"

#-----------------------------------------------------------------------------
Expand Down
13 changes: 2 additions & 11 deletions src/bokeh/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,8 @@
from enum import Enum, auto
from os.path import join
from pathlib import Path
from typing import (
TYPE_CHECKING,
Any,
Callable,
Generic,
Literal,
Sequence,
TypeAlias,
TypeVar,
cast,
)
from typing import (TYPE_CHECKING, Any, Callable, Generic, Literal, Sequence,
TypeAlias, TypeVar, cast)

# External imports
import yaml
Expand Down