Skip to content

⚡️ Speed up function _pop_renderer_args by 172% #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up function _pop_renderer_args by 172% #65

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57d46d6
Optimize _pop_renderer_args
codeflash-ai[bot] Oct 28, 2025
641ef0e
cleanup
misrasaurabh1 Nov 7, 2025
532fd98
cleanup
misrasaurabh1 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/bokeh/plotting/_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@
#-----------------------------------------------------------------------------
from __future__ import annotations

from bokeh.models import ColumnDataSource

Copy link

@misrasaurabh1 misrasaurabh1 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from bokeh.models import ColumnDataSource

Copy link

@misrasaurabh1 misrasaurabh1 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from bokeh.models import ColumnDataSource

import logging # isort:skip

Copy link

@misrasaurabh1 misrasaurabh1 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link

@misrasaurabh1 misrasaurabh1 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

log = logging.getLogger(__name__)

#-----------------------------------------------------------------------------
Expand Down Expand Up @@ -255,7 +258,10 @@ def _convert_data_source(kwargs: Attrs) -> bool:

def _pop_renderer_args(kwargs: Attrs) -> Attrs:
result = {attr: kwargs.pop(attr) for attr in RENDERER_ARGS if attr in kwargs}
result['data_source'] = kwargs.pop('source', ColumnDataSource())
if 'source' in kwargs:
result['data_source'] = kwargs.pop('source')
else:
result['data_source'] = ColumnDataSource()
return result

def _process_sequence_literals(glyphclass: type[Glyph], kwargs: Attrs, source: ColumnarDataSource, is_user_source: bool) -> list[str]:
Expand Down