-
Notifications
You must be signed in to change notification settings - Fork 19
Add better hints for string type mismatch #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
internal/test_helpers/fixtures/ping-pong/string_type_mismatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| Debug = true | ||
|
|
||
| [33m[tester::#RG2] [0m[94mRunning tests for Stage #RG2 (rg2)[0m | ||
| [33m[tester::#RG2] [0m[94m$ ./spawn_redis_server.sh[0m | ||
| [33m[your_program] [0mhey, binding to 6379 | ||
| [33m[tester::#RG2] [0m[36mConnection established, sending ping command...[0m | ||
| [33m[tester::#RG2] [client] [0m[94m$ redis-cli PING[0m | ||
| [33m[tester::#RG2] [client] [0m[36mSent bytes: "*1\r\n$4\r\nPING\r\n"[0m | ||
| [33m[tester::#RG2] [client] [0m[36mReceived bytes: "$4\r\nPONG\r\n"[0m | ||
| [33m[tester::#RG2] [client] [0m[36mReceived RESP bulk string: "PONG"[0m | ||
| [33m[tester::#RG2] [0m[91mExpected simple string "PONG", got bulk string "PONG" instead[0m | ||
| [33m[tester::#RG2] [0m[91mTest failed[0m | ||
| [33m[tester::#RG2] [0m[36mTerminating program[0m | ||
| [33m[tester::#RG2] [0m[36mProgram terminated successfully[0m |
5 changes: 5 additions & 0 deletions
5
internal/test_helpers/scenarios/ping-pong/string_type_mismatch/codecrafters.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Set this to true if you want debug logs. | ||
| # | ||
| # These can be VERY verbose, so we suggest turning them off | ||
| # unless you really need them. | ||
| debug: true |
15 changes: 15 additions & 0 deletions
15
internal/test_helpers/scenarios/ping-pong/string_type_mismatch/spawn_redis_server.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| #!/usr/bin/env -S python3 -u | ||
| import socket | ||
| import time | ||
| print("hey, binding to 6379") | ||
| sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) | ||
| sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1) | ||
|
|
||
| sock.bind(('', 6379)) | ||
|
|
||
| sock.listen(1) | ||
|
|
||
| conn, cli_addr = sock.accept() | ||
|
|
||
| # Send bulk string instead of simple string | ||
| conn.send(b"$4\r\nPONG\r\n") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.