Move git binary before starting tests

[ryan-gang]

Introduce a command-line tool for basic Git operations and streamline repository cloning. Enhance testing capabilities with Docker support and manage Git executables in temporary directories for isolated testing. Update dependencies and improve build scripts for cross-platform compatibility. Remove obsolete configurations and binaries.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Triggered a Github Actions job to update fixtures.

[rohitpaulk]

Notes added

[cursor]

Bug: `restoreSystemGit` Function Security and Error Handling Flaws

The restoreSystemGit function has multiple issues:

• Shell Injection Vulnerability: The mv command is constructed by directly interpolating unescaped paths, creating a shell injection risk.
• Inconsistent Error Handling: The function declares an error return type but always panics on failure and returns nil on success, never returning an actual error value. This panicking behavior, especially when used as a teardown function, can mask the true cause of test failures.
• Incorrect Error Message: The panic message for os.RemoveAll incorrectly formats the directory path instead of the actual error.

internal/utils.go#L40-L55

git-tester/internal/utils.go

Lines 40 to 55 in 3fa89a6

	// RestoreSystemGit moves the git binary back to its original location and cleans up
	func restoreSystemGit(newPath string, originalPath string) error {
	command := fmt.Sprintf("mv %s %s", newPath, originalPath)
	moveCmd := exec.Command("sh", "-c", command)
	moveCmd.Stdout = io.Discard
	moveCmd.Stderr = io.Discard
	if err := moveCmd.Run(); err != nil {
	panic(fmt.Sprintf("CodeCrafters Internal Error: mv restore for git failed: %v", err))
	}
	if err := os.RemoveAll(path.Dir(newPath)); err != nil {
	panic(fmt.Sprintf("CodeCrafters Internal Error: delete tmp git directory failed: %s", path.Dir(newPath)))
	}
	return nil
	}

Fix in Cursor • Fix in Web

---

Bug: Script Overwrites Global Git Settings

The script modifies global Git configuration by setting init.defaultBranch to main. This change persists after test execution and can overwrite a developer's existing global Git settings, affecting their workflow outside the test environment. It should use local configuration instead.

internal/test_helpers/pass_all/your_program.sh#L13-L17

git-tester/internal/test_helpers/pass_all/your_program.sh

Lines 13 to 17 in 3fa89a6

	if [ -x "$tmpdir" ]; then
	# If defaultBranch config is not set, we set it to main (doesn't work without global config)
	if ! "$tmpdir" config --global --get init.defaultBranch >/dev/null 2>&1; then
	"$tmpdir" config --global init.defaultBranch main
	fi

Fix in Cursor • Fix in Web

---

Bug: CI Test Privilege Escalation Issue

The CI workflow's change to sudo make test will cause failures in environments where sudo is unavailable (e.g., some Docker containers). This also introduces unnecessary security risks by elevating test execution privileges.

.github/workflows/test.yml#L21-L22

git-tester/.github/workflows/test.yml

Lines 21 to 22 in 3fa89a6

	- run: sudo make test

Fix in Cursor • Fix in Web

---

Bug: Shell Injection and Error Handling Issues

Shell injection vulnerability exists in RelocateSystemGit and restoreSystemGit where mv commands are built by directly interpolating unescaped paths into sh -c, enabling command injection. Additionally, the restoreSystemGit function's error return value is ignored by the registered teardown function, which could lead to silent cleanup failures.

internal/utils.go#L26-L37

git-tester/internal/utils.go

Lines 26 to 37 in 3fa89a6

	command := fmt.Sprintf("mv %s %s", oldGitPath, tmpGitPath)
	moveCmd := exec.Command("sh", "-c", command)
	moveCmd.Stdout = io.Discard
	moveCmd.Stderr = io.Discard
	if err := moveCmd.Run(); err != nil {
	os.RemoveAll(tmpGitDir)
	panic(fmt.Sprintf("CodeCrafters Internal Error: mv git to tmp directory failed: %v", err))
	}
	// Register teardown function to automatically restore git
	harness.RegisterTeardownFunc(func() { restoreSystemGit(tmpGitPath, oldGitPath) })

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[rohitpaulk]

Note added

[rohitpaulk]

Seems weird behaviour to not do this here too. Can't we move the git binary back for verifying and then place it back again?

[rohitpaulk]

Or can we just use the path of the temporary git to execute that?