Code review notes #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

omriAckley wants to merge 1 commit into master from code-review

Collaborator

omriAckley commented Nov 30, 2015

Project/page two way references (could run into synchronization issues).
Project/user two way references (could run into synchronization issues).
Grid factory is pretty large, consider splitting it up somehow.
In general get rid of that dead code.
Really appreciate how lightweight the create layout controller is!


          Add feedback notes

e87d21b

sunilunka added the in progress label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels