Adjust mutation error responses #670

Knerio · 2025-11-13T20:46:20Z

close #646

Copilot

Pull Request Overview

This PR refactors the GraphQL mutation error response structure to use a consistent error handling pattern. The changes move from a union-based error system to an object-based approach where errors have an errorCode field and an optional details array for additional error information.

Key changes include:

Restructuring the Error GraphQL type from a union to an object with errorCode and details fields
Updating ServiceResponse.error() to require an error_code parameter and use a structured payload format
Adding new error codes to the ErrorCodeEnum for better error classification
Creating a new DetailedError union type for the details field to handle different error detail types

Reviewed Changes

Copilot reviewed 183 out of 183 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
app/services/service_response.rb	Refactored error method to require error_code and structure payload consistently
app/graphql/types/errors/error_type.rb	Changed from union to object type with errorCode and details fields
app/graphql/types/errors/detailed_error_type.rb	New union type for detailed error information
lib/sagittarius/graphql/error_container.rb	Renamed and restructured to hold error_code and details
app/services/error_code.rb	Added many new error code definitions
app/services//.rb	Updated all service error responses to use new format
app/graphql/mutations/base_mutation.rb	Updated create_error helper to use new ErrorContainer structure
spec/support/helpers/graphql_helpers.rb	Updated error_query helper to match new error structure
spec/*/_spec.rb	Updated all specs to access errors via new structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

spec/support/helpers/graphql_helpers.rb

spec/services/users/identity/register_service_spec.rb

app/services/users/logout_service.rb

app/services/users/identity/register_service.rb

app/services/files/upload_service.rb

app/graphql/mutations/namespaces/projects/flows/create.rb

github-actions · 2025-11-13T20:52:43Z

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2157719082

Status: Passed
Duration: 4 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12083610674/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2157719082/test_report
Finished in 22.81 seconds (files took 12.74 seconds to load)
1188 examples, 0 failures
Line Coverage: 91.45% (4023 / 4399)
[TEST PROF INFO] Time spent in factories: 00:11.896 (41.85% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12083610673/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2157719082/test_report
Finished in 19.72 seconds (files took 13.86 seconds to load)
1141 examples, 0 failures
Line Coverage: 90.84% (3856 / 4245)
[TEST PROF INFO] Time spent in factories: 00:10.021 (36.88% of total time)

rubocop

669 files inspected, no offenses detected

Knerio · 2025-11-13T20:58:57Z

@copilot did i fix your suggestions correctly?

Copilot · 2025-11-13T20:59:04Z

@Knerio I've opened a new pull request, #671, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull Request Overview

Copilot reviewed 183 out of 183 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

app/graphql/types/errors/flow_validation_error_type.rb

spec/services/users/identity/register_service_spec.rb

app/services/error_code.rb

Copilot · 2025-11-13T21:04:25Z

@Knerio I've opened a new pull request, #672, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-13T21:04:26Z

@Knerio I've opened a new pull request, #673, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-13T21:04:27Z

@Knerio I've opened a new pull request, #674, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-13T21:25:32Z

@Knerio I've opened a new pull request, #680, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Knerio <96529060+Knerio@users.noreply.github.com>

Copilot · 2025-11-13T21:25:57Z

@Knerio I've opened a new pull request, #681, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-13T21:26:07Z

@Knerio I've opened a new pull request, #682, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Knerio <96529060+Knerio@users.noreply.github.com>

Fix grammar typo in FlowValidationErrorType description

Co-authored-by: Knerio <96529060+Knerio@users.noreply.github.com>

Add missing invalid_totp_secret error code definition

Add missing organization_not_found error code

Add missing email_verification_send_failed error code definition

Copilot

Pull Request Overview

Copilot reviewed 183 out of 183 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

app/services/error_code.rb

Copilot · 2025-11-13T21:43:53Z

@Knerio I've opened a new pull request, #684, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Knerio <96529060+Knerio@users.noreply.github.com>

Fix invalid_namespace_member error code description

Copilot

Pull Request Overview

Copilot reviewed 183 out of 183 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

app/services/files/upload_service.rb

app/services/namespaces/projects/flows/validation/flow_validation_error_code.rb

app/services/namespaces/projects/flows/validation/validation_result.rb

Knerio added 3 commits November 13, 2025 19:30

Update graphql layer for new error system

1bf86d9

Fix error structure

87a46c9

Implement new error response code in all services and mutation

749ceb5

Knerio changed the title ~~djust mutation error responses~~ Adjust mutation error responses Nov 13, 2025

Knerio requested a review from Taucher2003 November 13, 2025 20:47

Knerio self-assigned this Nov 13, 2025

Knerio requested a review from Copilot November 13, 2025 20:47

Copilot started reviewing on behalf of Knerio November 13, 2025 20:47 View session

Copilot finished reviewing on behalf of Knerio November 13, 2025 20:48

Copilot AI reviewed Nov 13, 2025

View reviewed changes

Knerio requested a review from Copilot November 13, 2025 20:58

Copilot AI mentioned this pull request Nov 13, 2025

Fix remaining tab indentation in graphql_helpers.rb #671

Closed

Copilot started reviewing on behalf of Knerio November 13, 2025 20:59 View session

Copilot finished reviewing on behalf of Knerio November 13, 2025 21:00

Copilot AI reviewed Nov 13, 2025

View reviewed changes

app/graphql/types/errors/flow_validation_error_type.rb Outdated Show resolved Hide resolved

spec/services/users/identity/register_service_spec.rb Outdated Show resolved Hide resolved

app/services/error_code.rb Outdated Show resolved Hide resolved

Knerio force-pushed the 646-adjust-mutation-error-responses branch from 2ac052a to 586839c Compare November 13, 2025 21:03

Copilot AI mentioned this pull request Nov 13, 2025

Fix grammar: "an flow" → "a flow" #672

Closed

Copilot AI mentioned this pull request Nov 13, 2025

Fix frozen_string_literal magic comment indentation #673

Closed

Copilot AI mentioned this pull request Nov 13, 2025

Fix invalid_namespace_member error description copy-paste error #674

Closed

Knerio force-pushed the 646-adjust-mutation-error-responses branch from 586839c to 3436d5f Compare November 13, 2025 21:05

fix some suggestions from copilot

15f4545

Knerio force-pushed the 646-adjust-mutation-error-responses branch from 3436d5f to 15f4545 Compare November 13, 2025 21:18

Knerio requested a review from Copilot November 13, 2025 21:18

Copilot started reviewing on behalf of Knerio November 13, 2025 21:18 View session

Copilot AI mentioned this pull request Nov 13, 2025

Add missing email_verification_send_failed error code definition #680

Merged

Copilot AI and others added 2 commits November 13, 2025 21:25

Add missing invalid_totp_secret error code to error_codes hash

152e74e

Co-authored-by: Knerio <96529060+Knerio@users.noreply.github.com>

Initial plan

168e7a2

Copilot AI mentioned this pull request Nov 13, 2025

Add missing organization_not_found error code #681

Merged

Copilot AI mentioned this pull request Nov 13, 2025

Add space after opening brace in GraphQL inline fragment #682

Closed

Copilot AI and others added 4 commits November 13, 2025 21:28

Add organization_not_found error code to error_codes hash

8e6c712

Co-authored-by: Knerio <96529060+Knerio@users.noreply.github.com>

Merge pull request #679 from code0-tech/copilot/sub-pr-670-yet-again

6d279ab

Fix grammar typo in FlowValidationErrorType description

Add missing email_verification_send_failed error code

b6a357a

Co-authored-by: Knerio <96529060+Knerio@users.noreply.github.com>

Merge pull request #678 from code0-tech/copilot/sub-pr-670-another-one

83600fc

Add missing invalid_totp_secret error code definition

Knerio force-pushed the 646-adjust-mutation-error-responses branch from f141a3d to 83600fc Compare November 13, 2025 21:33

Knerio added 2 commits November 13, 2025 22:35

Merge pull request #681 from code0-tech/copilot/sub-pr-670-please-work

54d0b4d

Add missing organization_not_found error code

Merge pull request #680 from code0-tech/copilot/sub-pr-670-one-more-time

a97881e

Add missing email_verification_send_failed error code definition

Knerio force-pushed the 646-adjust-mutation-error-responses branch from 312798c to a97881e Compare November 13, 2025 21:37

Knerio requested a review from Copilot November 13, 2025 21:37

Copilot started reviewing on behalf of Knerio November 13, 2025 21:38 View session

Copilot finished reviewing on behalf of Knerio November 13, 2025 21:40

Copilot AI reviewed Nov 13, 2025

View reviewed changes

app/services/error_code.rb Outdated Show resolved Hide resolved

Initial plan

ca54ad1

Copilot AI mentioned this pull request Nov 13, 2025

Fix invalid_namespace_member error code description #684

Merged

Copilot AI and others added 2 commits November 13, 2025 21:47

Fix invalid_namespace_member error code description

9589eb1

Co-authored-by: Knerio <96529060+Knerio@users.noreply.github.com>

Merge pull request #684 from code0-tech/copilot/sub-pr-670-another-one

f68fb15

Fix invalid_namespace_member error code description

Knerio force-pushed the 646-adjust-mutation-error-responses branch from fecb40c to f68fb15 Compare November 13, 2025 21:56

Knerio requested a review from Copilot November 13, 2025 22:02

Copilot started reviewing on behalf of Knerio November 13, 2025 22:03 View session

Copilot finished reviewing on behalf of Knerio November 13, 2025 22:04

Copilot AI reviewed Nov 13, 2025

View reviewed changes

app/services/files/upload_service.rb Show resolved Hide resolved

app/services/namespaces/projects/flows/validation/flow_validation_error_code.rb Show resolved Hide resolved

app/services/namespaces/projects/flows/validation/validation_result.rb Show resolved Hide resolved

Adjust mutation error responses #670

Are you sure you want to change the base?

Adjust mutation error responses #670

Conversation

Knerio commented Nov 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitLab Pipeline Action

General information

Job summaries

rspec: [ee]

rspec: [ce]

rubocop

Uh oh!

Knerio commented Nov 13, 2025

Uh oh!

Copilot AI commented Nov 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Nov 13, 2025

Uh oh!

Copilot AI commented Nov 13, 2025

Uh oh!

Copilot AI commented Nov 13, 2025

Uh oh!

Copilot AI commented Nov 13, 2025

Uh oh!

Copilot AI commented Nov 13, 2025

Uh oh!

Copilot AI commented Nov 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI commented Nov 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Nov 13, 2025 •

edited

Loading